Difference between revisions of "Compensation"

From Bisq Wiki
Jump to navigation Jump to search
(add note on linting compensation requests)
Line 51: Line 51:
 
To more efficiently evaluate issuance for budgeting, compensation requests are parsed by a bot. This bot requires that compensation requests follow a particular format. This format is detailed in the placeholder text for new compensation request issues—just follow the guidelines there, and/or look at other requests if you're not sure about something.
 
To more efficiently evaluate issuance for budgeting, compensation requests are parsed by a bot. This bot requires that compensation requests follow a particular format. This format is detailed in the placeholder text for new compensation request issues—just follow the guidelines there, and/or look at other requests if you're not sure about something.
  
Requests are linted as soon as they are ready for review (i.e., as soon as <code>[WIP]</code> is removed from the issue title). A request is labeled <code>parsed:valid</code> if it's valid, <code>parsed:invalid</code> if it's not. If invalid, a comment is added indicating the error. Please watch for this label and fix any errors the linter finds.
+
Requests are parsed as soon as they are ready for review (i.e., as soon as <code>[WIP]</code> is removed from the issue title). A request is labeled <code>parsed:valid</code> if it's valid, <code>parsed:invalid</code> if it's not. If invalid, a comment is added indicating the error. Please watch for this label and fix any errors the parser finds.
  
 
==== Incorporate review feedback for your request ====
 
==== Incorporate review feedback for your request ====

Revision as of 08:28, 16 June 2020

Processes by role

Compensation Maintainer

Announce BSQ-USD exchange rate

Compensation requests should use a 90-day volume weighted average to calculate a value for BSQ and mitigate its volatility. At the end of a Bisq DAO Cycle and beginning of a new one, the Compensation Maintainer should create a pinned issue with the title: BSQ rate for Cycle X is Y.YY USD per 1 BSQ and a screenshot of DAO Dashboard to announce the rates for the ongoing cycle.

Announce request submission deadline

To give time for team leads to discuss and review Compensation Requests, requests need to be Ready for review one week prior to the end of current cycle's proposal phase.

Compensation board

The date and reminders will be announced at @bisq-network/dao, the Compensation board and the Events Calendar

Triage incoming requests

The Compensation Maintainer watches the compensation repository and proceeds to triage:

Incoming issues are classified as Work in progress if they have [WIP] at the beginning of the title or as In Review if they don't. Compensation Maintainer assigns 'In review' issues to corresponding team leads after looking at the content of the request. When in doubt, Compensation Maintainer should ask in the issue which team leaders are the appropriate for the issue.

The Compensation Maintainer should transition reviewed requests with DAO proposals transaction ID submitted to Proposal Submitted column.

Triage is controlled from the Compensation board, drag-and-dropping issues and using "add cards" to triage incoming issues, and directly from the issues, using the "projects" section in the right sidebar.

Archive previous cycle requests at the end of the proposal phase

At the completion of the current cycle's proposal phase, the Compensation Maintainer should archive all issues in the Done column from the previous phase.

The reason for waiting to archive these issues is so that contributors can easily see how many requests were made in the last phase, to quickly find their own prior request, and to to easily review which ones were accepted and rejected. We archive them at the end of the proposal phase in order to keep the board clean and make room for requests in the current phase to populate the Done column.

Close current cycle requests after the vote reveal phase

When the reveal vote phase is complete, the Compensation Maintainer should take the following steps:

  1. Label each compensation request issue as was:accepted or was:rejected according to the vote result
  2. Close the issue with a comment that reads "Closing as accepted" or "Closing as rejected".

Once closed, the issues will automatically transition to the Done column of the board where they remain for reference until they are archived at the end of the next cycle's proposal phase (as per the section above).


Contributor

Create your compensation request issue

If you wish to request compensation for the current cycle, you should create a compensation request issue no later than one week prior to the end of the current cycle's proposal phase. This is in order to allow time for review by your Team Lead. Reminders about this deadline are sent every cycle to the @bisq-network/dao team, so you should make sure you are watching discussions for that team.

WIP (Work in Progress) compensation requests may be submitted with a [WIP] prefix in the title, e.g. [WIP] For Cycle 10. Such WIP requests are assumed not to be ready for review until the WIP prefix is removed. This allows you a convenient way to incrementally add content to a compensation request throughout the course of a cycle without triggering a review prematurely. To indicate that a WIP compensation request is now ready for review, remove the [WIP] prefix from the compensation request issue and add a comment stating "This request is ready for review". Any compensation request submitted without a WIP prefix will be assumed to be ready for review.

Ensure your request is valid

To more efficiently evaluate issuance for budgeting, compensation requests are parsed by a bot. This bot requires that compensation requests follow a particular format. This format is detailed in the placeholder text for new compensation request issues—just follow the guidelines there, and/or look at other requests if you're not sure about something.

Requests are parsed as soon as they are ready for review (i.e., as soon as [WIP] is removed from the issue title). A request is labeled parsed:valid if it's valid, parsed:invalid if it's not. If invalid, a comment is added indicating the error. Please watch for this label and fix any errors the parser finds.

Incorporate review feedback for your request

When your team lead or other stakeholders review your compensation request, they will provide any feedback or requests for changes in the form of a comment on your request issue. Please respond to it promptly. When there is no further feedback, your team lead will add a comment asking you to submit this compensation request as a DAO proposal. The instructions how to do so are in the next section.

Submit your request as a DAO proposal

Follow the instructions on how to file your compensation request as a DAO proposal. When complete, add a comment to your proposal issue that includes the transaction ID of your proposal.

Team Lead

Review team member requests

When a team lead is assigned to a compensation request issue, they should promptly review it with regard to whether the work meets the definition of delivered, and whether it fits within the team budget. The team lead should add feedback and comments as a appropriate, and assign the contributor to the issue to indicate that they are expected to respond to the review.

When the review process is complete, i.e. all team lead feedback has been addressed, the team lead should add a comment asking the contributor to submit their proposal to DAO and to post the resulting TXID in a comment.

Stakeholder

Review contributor requests

Remember that just as stakeholders may vote on any DAO proposal, stakeholders may review any contributor's compensation request. To do so, simply add your review feedback in the form of a comment, and react to the compensation request issue with a thumbs-up, thumbs-down or confused face emoji as appropriate. Note that with the exception of team leads, there is no obligation to perform these reviews, and in general you should only review compensation requests that you are knowledgeable about.